Skip to content

[19.2.x]: Migrate manual_api_docs and compiler-cli/src/ngtsc to rules_js#61237

Closed
devversion wants to merge 5 commits intoangular:19.2.xfrom
devversion:patch-rjs-2
Closed

[19.2.x]: Migrate manual_api_docs and compiler-cli/src/ngtsc to rules_js#61237
devversion wants to merge 5 commits intoangular:19.2.xfrom
devversion:patch-rjs-2

Conversation

@devversion
Copy link
Copy Markdown
Member

@devversion devversion commented May 9, 2025

See individual commits. Patch port of #61181

devversion added 4 commits May 9, 2025 10:32
Prepare the compiler-cli package for being ready for migration
to `ts_project`.
Migrates `compiler-cli/src/ngtsc/docs` to `ts_project`.
Migrates `manual_api_docs` to `rules_js`. Since compiler CLI is ESM
compiled but doesn't have extensions, we can either bundle or simply use
the dependency as type only. This is easier and sufficient for this
use-case.
Migrates all of `compiler-cli/src/ngtsc` to `ts_project`. This change
was generated using Gemini.
@devversion devversion changed the base branch from main to 19.2.x May 9, 2025 10:55
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 9, 2025
@ngbot ngbot bot added this to the Backlog milestone May 9, 2025
This log output doesn't provide any benefit anymore, so we can remove it.
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 9, 2025
@devversion devversion requested a review from josephperrott May 9, 2025 11:24
@devversion devversion marked this pull request as ready for review May 9, 2025 11:24
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 9, 2025
@josephperrott
Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 6cd2df0.

The changes were merged into the following branches: 19.2.x

josephperrott pushed a commit that referenced this pull request May 9, 2025
Prepare the compiler-cli package for being ready for migration
to `ts_project`.

PR Close #61237
josephperrott pushed a commit that referenced this pull request May 9, 2025
Migrates `compiler-cli/src/ngtsc/docs` to `ts_project`.

PR Close #61237
josephperrott pushed a commit that referenced this pull request May 9, 2025
Migrates `manual_api_docs` to `rules_js`. Since compiler CLI is ESM
compiled but doesn't have extensions, we can either bundle or simply use
the dependency as type only. This is easier and sufficient for this
use-case.

PR Close #61237
josephperrott pushed a commit that referenced this pull request May 9, 2025
Migrates all of `compiler-cli/src/ngtsc` to `ts_project`. This change
was generated using Gemini.

PR Close #61237
josephperrott pushed a commit that referenced this pull request May 9, 2025
This log output doesn't provide any benefit anymore, so we can remove it.

PR Close #61237
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants