Skip to content

fix(common): cleanup updateLatestValue if view is destroyed before promise resolves [patch] #61064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arturovt wants to merge 1 commit into from
Closed

fix(common): cleanup updateLatestValue if view is destroyed before promise resolves [patch] #61064

arturovt wants to merge 1 commit into from

Conversation

@arturovt
Copy link
Contributor

@arturovt arturovt commented Apr 30, 2025

Patch version of #58041.

@pullapprove pullapprove bot requested a review from devversion April 30, 2025 15:58
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Apr 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2025
@arturovt arturovt changed the title fix(common): cleanup updateLatestValue if view is destroyed before promise resolves fix(common): cleanup updateLatestValue if view is destroyed before promise resolves [patch] Apr 30, 2025
@thePunderWoman thePunderWoman added the target: patch This PR is targeted for the next patch release label Apr 30, 2025
thePunderWoman
thePunderWoman approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman removed the request for review from devversion April 30, 2025 16:13
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Apr 30, 2025
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 30, 2025

Marking this PR as blocked for now, since we need to run a TGP for the main PR #58041.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented May 1, 2025

This PR was merged into the repository by commit 89056a0.

The changes were merged into the following branches: 19.2.x

AndrewKushnir pushed a commit that referenced this pull request May 1, 2025
@arturovt @AndrewKushnir
fix(common): cleanup updateLatestValue if view is destroyed before …
89056a0 
…promise resolves (#61064)

Patch version of #58041.

PR Close #61064
@arturovt arturovt deleted the fix/async_pipe_leak_patch branch May 1, 2025 22:15
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 1, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@arturovt @AndrewKushnir @thePunderWoman