fix(core): properly handle app stabilization with defer blocks#61040
Closed
alan-agius4 wants to merge 6 commits intoangular:mainfrom
Closed
fix(core): properly handle app stabilization with defer blocks#61040alan-agius4 wants to merge 6 commits intoangular:mainfrom
alan-agius4 wants to merge 6 commits intoangular:mainfrom
Conversation
Add an integration test to verify defer block behavior with input handling during server-side rendering (SSR).
Add an integration test to verify SSR with zoneless
A number of cases currently do not work with zoneless.
devversion
reviewed
Apr 29, 2025
integration/platform-server-zoneless/e2e/src/http-transferstate-lazy-on-init-spec.ts
Outdated
Show resolved
Hide resolved
...oneless/projects/standalone/src/app/http-transferstate-lazy/http-transfer-state.component.ts
Outdated
Show resolved
Hide resolved
atscott
reviewed
Apr 29, 2025
50e10bb to
e83286e
Compare
Previously, the app was marked as stable prematurely. For more details, see angular#61038 (comment) Closes: angular#61038
e83286e to
de649c9
Compare
thePunderWoman
approved these changes
Apr 29, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM! Thanks for digging into this from the tooling side. It's certainly a fun one.
atscott
approved these changes
Apr 29, 2025
devversion
approved these changes
Apr 29, 2025
|
Will the fix be included in the v19 branch as well? |
9556563 to
b933c44
Compare
Contributor
Author
Yes, there is a separate PR for that #61056 |
Contributor
Author
|
caretaker note: the lint is the usual license check failure |
Contributor
|
This PR was merged into the repository by commit 193bd7c. The changes were merged into the following branches: main, 20.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2025
Add an integration test to verify SSR with zoneless PR Close #61040
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2025
Previously, the app was marked as stable prematurely. For more details, see #61038 (comment) Closes: #61038 PR Close #61040
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2025
Add an integration test to verify SSR with zoneless PR Close #61040
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2025
Previously, the app was marked as stable prematurely. For more details, see #61038 (comment) Closes: #61038 PR Close #61040
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the app was marked as stable prematurely. For more details, see #61038 (comment)
Closes: #61038