refactor(core): expose getCleanupHook via private exports#61017
Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
Closed
refactor(core): expose getCleanupHook via private exports#61017alan-agius4 wants to merge 2 commits intoangular:mainfrom
getCleanupHook via private exports#61017alan-agius4 wants to merge 2 commits intoangular:mainfrom
Conversation
Expose `getCleanupHook` as a private export to address integration issues with Vitest. In Vitest, `globalThis.beforeEach` and `globalThis.afterEach` are not available by default. Additionally, these hooks are patched during module evaluation, complicating seamless integration with Vitest. See: angular/angular-cli#30188
Contributor
|
@alan-agius4 looks like you need to update the goldens |
Contributor
|
This PR was merged into the repository by commit c037c58. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
getCleanupHookas a private export to address integration issues with Vitest. In Vitest,globalThis.beforeEachandglobalThis.afterEachare not available by default. Additionally, these hooks are patched during module evaluation, complicating seamless integration with Vitest.See: angular/angular-cli#30188