refactor(core): expose getCleanupHook via private exports (#61017)

alan-agius4 · mmalerba · commit c037c589958f · 2025-04-29T10:30:17.000-07:00
Expose `getCleanupHook` as a private export to address integration issues with Vitest. In Vitest, `globalThis.beforeEach` and `globalThis.afterEach` are not available by default. Additionally, these hooks are patched during module evaluation, complicating seamless integration with Vitest. See: angular/angular-cli#30188 PR Close #61017
diff --git a/packages/core/testing/src/test_hooks.ts b/packages/core/testing/src/test_hooks.ts
@@ -27,7 +27,7 @@ globalThis.beforeEach?.(getCleanupHook(false));
 // afterEach is only defined when executing the tests
 globalThis.afterEach?.(getCleanupHook(true));
 
-function getCleanupHook(expectedTeardownValue: boolean) {
+export function getCleanupHook(expectedTeardownValue: boolean): VoidFunction {
   return () => {
     const testBed = TestBedImpl.INSTANCE;
     if (testBed.shouldTearDownTestingModule() === expectedTeardownValue) {
diff --git a/packages/core/testing/src/testing.ts b/packages/core/testing/src/testing.ts
@@ -38,7 +38,7 @@ export {
   TestEnvironmentOptions,
   ModuleTeardownOptions,
 } from './test_bed_common';
-export * from './test_hooks';
+export {__core_private_testing_placeholder__} from './test_hooks';
 export * from './metadata_override';
 export {MetadataOverrider as ɵMetadataOverrider} from './metadata_overrider';
 export {
diff --git a/packages/core/testing/src/testing_private_export.ts b/packages/core/testing/src/testing_private_export.ts
@@ -7,3 +7,4 @@
  */
 
 export {FakeNavigation as ɵFakeNavigation} from '../../primitives/dom-navigation/testing';
+export {getCleanupHook as ɵgetCleanupHook} from './test_hooks';

Original file line number	Diff line number	Diff line change
`@@ -7,3 +7,4 @@`
`7`	`7`	`*/`
`8`	`8`
`9`	`9`	`export {FakeNavigation as ɵFakeNavigation} from '../../primitives/dom-navigation/testing';`
	`10`	`+export {getCleanupHook as ɵgetCleanupHook} from './test_hooks';`