refactor(core): tree-shake PROPAGATION_STOPPED_SYMBOL#61004
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): tree-shake PROPAGATION_STOPPED_SYMBOL#61004arturovt wants to merge 1 commit intoangular:mainfrom
PROPAGATION_STOPPED_SYMBOL#61004arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
Adds `__PURE__` annotations to `PROPAGATION_STOPPED_SYMBOL` to enable tree-shaking, even if is is not referenced. This variable is not dropped when Angular is imported from a module that has `sideEffects` set to `true`.
pkozlowski-opensource
approved these changes
Apr 30, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: primitives
iteriani
approved these changes
Apr 30, 2025
Contributor
|
LGTM Reviewed-for: primitives-shared |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2025
Adds `__PURE__` annotations to `PROPAGATION_STOPPED_SYMBOL` to enable tree-shaking, even if is is not referenced. This variable is not dropped when Angular is imported from a module that has `sideEffects` set to `true`. PR Close #61004
Contributor
|
This PR was merged into the repository by commit 13fd1b3. The changes were merged into the following branches: main, 19.2.x, 20.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 30, 2025
Adds `__PURE__` annotations to `PROPAGATION_STOPPED_SYMBOL` to enable tree-shaking, even if is is not referenced. This variable is not dropped when Angular is imported from a module that has `sideEffects` set to `true`. PR Close #61004
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
__PURE__annotations toPROPAGATION_STOPPED_SYMBOLto enable tree-shaking, even if is is not referenced. This variable is not dropped when Angular is imported from a module that hassideEffectsset totrue.