Skip to content

linkedSignal type inference docs/tests#60857

Closed
JoostK wants to merge 2 commits intoangular:mainfrom
JoostK:core/linked-signal-inference
Closed

linkedSignal type inference docs/tests#60857
JoostK wants to merge 2 commits intoangular:mainfrom
JoostK:core/linked-signal-inference

Conversation

@JoostK
Copy link
Copy Markdown
Member

@JoostK JoostK commented Apr 13, 2025

See individual commits.

Closes #60423

JoostK added 2 commits April 13, 2025 19:12
…e arguments

Due to the cyclic nature of `previous`'s type and the computation's return type,
TypeScript isn't able to infer generic type arguments.

Closes angular#60423
This commit adds type inference tests for `linkedSignal` usages, to capture their behavior w.r.t.
type inference. Note that there's some situations where type inference doesn't work as you might
expect/hope; these have been included to capture their behavior but may be revisited in the future
if the inference capabilities are expanded for this scenario.

Closes angular#60423
@JoostK JoostK added target: patch This PR is targeted for the next patch release core: reactivity Work related to fine-grained reactivity in the core framework labels Apr 13, 2025
@pullapprove pullapprove bot requested a review from alxhub April 13, 2025 17:16
@angular-robot angular-robot bot added area: docs Related to the documentation area: core Issues related to the framework runtime labels Apr 13, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 13, 2025
@JoostK JoostK added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 13, 2025
@pkozlowski-opensource pkozlowski-opensource removed the request for review from alxhub April 14, 2025 09:44
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 14, 2025
kirjs pushed a commit that referenced this pull request Apr 14, 2025
…e arguments (#60857)

Due to the cyclic nature of `previous`'s type and the computation's return type,
TypeScript isn't able to infer generic type arguments.

Closes #60423

PR Close #60857
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Apr 14, 2025

This PR was merged into the repository by commit 27bf809.

The changes were merged into the following branches: main, 19.2.x

kirjs pushed a commit that referenced this pull request Apr 14, 2025
This commit adds type inference tests for `linkedSignal` usages, to capture their behavior w.r.t.
type inference. Note that there's some situations where type inference doesn't work as you might
expect/hope; these have been included to capture their behavior but may be revisited in the future
if the inference capabilities are expanded for this scenario.

Closes #60423

PR Close #60857
@kirjs kirjs closed this in 6b9434a Apr 14, 2025
kirjs pushed a commit that referenced this pull request Apr 14, 2025
This commit adds type inference tests for `linkedSignal` usages, to capture their behavior w.r.t.
type inference. Note that there's some situations where type inference doesn't work as you might
expect/hope; these have been included to capture their behavior but may be revisited in the future
if the inference capabilities are expanded for this scenario.

Closes #60423

PR Close #60857
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: docs Related to the documentation core: reactivity Work related to fine-grained reactivity in the core framework target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type inference for advanced linkedSignal signature

4 participants