fix(core): fix ng generate @angular/core:output-migration.#60763
Closed
aparzi wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): fix ng generate @angular/core:output-migration.#60763aparzi wants to merge 1 commit intoangular:mainfrom
aparzi wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
reviewed
Apr 6, 2025
packages/core/schematics/migrations/output-migration/output-migration.spec.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Apr 6, 2025
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Apr 7, 2025
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/output-migration/output-migration.spec.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Apr 7, 2025
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
Apr 7, 2025
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
…lar#58650 Fixes angular#58650 - Insert a TODO comment for empty emit (without parameter).
JeanMeche
approved these changes
Apr 7, 2025
pkozlowski-opensource
approved these changes
Apr 8, 2025
Contributor
|
This PR was merged into the repository by commit 39a4e00. The changes were merged into the following branches: main, 19.2.x |
atscott
pushed a commit
that referenced
this pull request
Apr 8, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insert a TODO comment for emit function with no parameters
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After migration, event emitters of type @output that have a function with empty 'emit' (without any parameters) report an error because the 'emit' function expects a mandatory parameter.
Issue Number: #58650
What is the new behavior?
Insert a TODO comment for empty emit (without parameter).
Does this PR introduce a breaking change?