Skip to content

Docs: Fix Property Binding#60725

Closed
luk82 wants to merge 1 commit intoangular:mainfrom
luk82:propertyBindingDocFix
Closed

Docs: Fix Property Binding#60725
luk82 wants to merge 1 commit intoangular:mainfrom
luk82:propertyBindingDocFix

Conversation

@luk82
Copy link
Copy Markdown
Contributor

@luk82 luk82 commented Apr 3, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [x ] Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Bind to contentEditable contains an error where {{isEditable}} is incorrectly wrapped in curly braces, leading to a parser error.

Issue Number: N/A

What is the new behavior?

[contentEditable]="isEditable" code functions correctly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Screenshot 2025-04-03 at 09 43 36

@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from bencodezen April 3, 2025 08:57
JeanMeche
JeanMeche approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.
Can you please also sign the CLA.

@luk82
Copy link
Copy Markdown
Contributor Author

luk82 commented Apr 3, 2025

@JeanMeche Thanks! CLA signed.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 3, 2025
@JeanMeche JeanMeche force-pushed the propertyBindingDocFix branch from fd6141e to eec6e7a Compare April 3, 2025 09:22
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 3, 2025
@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 3, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 3, 2025
@JeanMeche JeanMeche mentioned this pull request Apr 3, 2025
Closed
14 tasks
@JeanMeche JeanMeche removed the request for review from bencodezen April 3, 2025 11:09
atscott pushed a commit that referenced this pull request Apr 3, 2025
@luk82 @atscott
docs: Fix Property Binding (#60725)
8d183ae 
PR Close #60725
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Apr 3, 2025

This PR was merged into the repository by commit 43cc57b.

The changes were merged into the following branches: main, 19.2.x

@atscott atscott closed this in 43cc57b Apr 3, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented May 4, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@luk82 @atscott @JeanMeche