Skip to content

docs: add Security-DomSanitizer link in ElemnetRef&Renderer2#60708

Closed
vladboisa wants to merge 3 commits intoangular:mainfrom
vladboisa:feat_add_secure_info
Closed

docs: add Security-DomSanitizer link in ElemnetRef&Renderer2#60708
vladboisa wants to merge 3 commits intoangular:mainfrom
vladboisa:feat_add_secure_info

Conversation

@vladboisa
Copy link
Copy Markdown
Contributor

@vladboisa vladboisa commented Apr 2, 2025

Renderer2 and ElementRef didn't mention the Security-DomSanitizer method, this will add clarity for potential user what to expect. Also swap deprecated "callout" class to docs-alert

Fixes #51208 , #46904

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #51208 , #46904

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto April 2, 2025 17:40
@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 2, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 2, 2025
@vladboisa
docs: add Security-DomSanitizer link in ElemnetRef&Renderer2
7665e5a 
Renderer2 and ElementRef didn't mention the Security-DomSanitizer method, this will add clarity for potential user what to expect. Also swap deprecated "callout" class to docs-alert

Fixes angular#51208 , angular#46904
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2025 •
edited
Loading

Deployed adev-preview for aa603a1 to: https://ng-dev-previews-fw--pr-angular-angular-60708-adev-prev-ne6h3rjj.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

JeanMeche
JeanMeche reviewed Apr 2, 2025
View reviewed changes
@angular-robot angular-robot bot added the area: docs-infra Angular.dev application and infrastructure label Apr 2, 2025
@vladboisa vladboisa requested a review from JeanMeche April 3, 2025 16:06
@JeanMeche JeanMeche requested review from thePunderWoman and removed request for crisbeto April 29, 2025 18:24
thePunderWoman
thePunderWoman approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 30, 2025
@mmalerba
Copy link
Copy Markdown
Contributor

mmalerba commented Apr 30, 2025

This PR was merged into the repository by commit a282f58.

The changes were merged into the following branches: main, 19.2.x

@mmalerba mmalerba closed this in e4a6676 Apr 30, 2025
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
@JeanMeche @mmalerba
docs(docs-infra): fix alert header inlining (#60708)
201e02b 
PR Close #60708
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
@vladboisa @mmalerba
docs: add link label & paragraph for correct display (#60708)
a282f58 
PR Close #60708
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
@vladboisa @mmalerba
docs: add Security-DomSanitizer link in ElemnetRef&Renderer2 (#60708)
770587a 
Renderer2 and ElementRef didn't mention the Security-DomSanitizer method, this will add clarity for potential user what to expect. Also swap deprecated "callout" class to docs-alert

Fixes #51208 , #46904

PR Close #60708
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
@JeanMeche @mmalerba
docs(docs-infra): fix alert header inlining (#60708)
4fb74b0 
PR Close #60708
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
@vladboisa @mmalerba
docs: add link label & paragraph for correct display (#60708)
0ee1a6e 
PR Close #60708
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented May 31, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Utilize DomSanitizer in Renderer2

4 participants

@vladboisa @mmalerba @JeanMeche @thePunderWoman