Skip to content

fix(core): fix ng generate @angular/core:signal-queries-migration#60688

Closed
aparzi wants to merge 1 commit intoangular:mainfrom
aparzi:retain-accesibility-modifier-signal-migrations
Closed

fix(core): fix ng generate @angular/core:signal-queries-migration#60688
aparzi wants to merge 1 commit intoangular:mainfrom
aparzi:retain-accesibility-modifier-signal-migrations

Conversation

@aparzi
Copy link
Copy Markdown
Contributor

@aparzi aparzi commented Apr 1, 2025

retain accessibility modifier if it's already present for signal migrations

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The command @angular/core:signal-queries-migration not retain accessibility modifier if it's already present for signal migrations

Issue Number: #59882

What is the new behavior?

Retain accessibility modifier if it's already present for signal migrations

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mmalerba April 1, 2025 23:19
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 1, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 1, 2025
@aparzi aparzi force-pushed the retain-accesibility-modifier-signal-migrations branch from 2be1733 to 8ff2a10 Compare April 2, 2025 07:01
@aparzi
Copy link
Copy Markdown
Contributor Author

aparzi commented Apr 2, 2025

Hi @JeanMeche,
I fixed lint and import errors

@aparzi aparzi requested a review from JeanMeche April 2, 2025 07:02
@JeanMeche JeanMeche requested review from devversion and removed request for mmalerba April 2, 2025 09:26
JeanMeche
JeanMeche approved these changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement.

@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Apr 2, 2025

@aparzi would you mind adding "Fixes #59882" to the commit message so the corresponding issue is closed automatically when this PR lands? Thnx!

@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Apr 2, 2025
@aparzi
fix(core): fixes #592882 ng generate @angular/core:signal-queries-mig…
865a9ab 
…ration

fixes #592882 - retain accessibility modifier if it's already present for signal migrations
@aparzi aparzi force-pushed the retain-accesibility-modifier-signal-migrations branch from 8ff2a10 to 865a9ab Compare April 2, 2025 10:25
@aparzi
Copy link
Copy Markdown
Contributor Author

aparzi commented Apr 2, 2025

@aparzi would you mind adding "Fixes #59882" to the commit message so the corresponding issue is closed automatically when this PR lands? Thnx!

Done

devversion
devversion approved these changes Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 2, 2025
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Apr 2, 2025

This PR was merged into the repository by commit 6acce7c.

The changes were merged into the following branches: main, 19.2.x

thePunderWoman pushed a commit that referenced this pull request Apr 2, 2025
@aparzi @thePunderWoman
fix(core): fixes #592882 ng generate @angular/core:signal-queries-mig…
006ac7f 
…ration (#60688)

fixes #592882 - retain accessibility modifier if it's already present for signal migrations

PR Close #60688
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Apr 2, 2025
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented May 3, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@aparzi @pkozlowski-opensource @thePunderWoman @JeanMeche @devversion