feat(core): move DOCUMENT token into core#60663
Closed
crisbeto wants to merge 2 commits intoangular:mainfrom
Closed
feat(core): move DOCUMENT token into core#60663crisbeto wants to merge 2 commits intoangular:mainfrom
crisbeto wants to merge 2 commits intoangular:mainfrom
Conversation
Moves the `DOCUMENT` token from `common` into `core` since it's relevant for lots of SSR use cases and users shouldn't have to install `common` for it. The token is still exported through `common` for backwards compatibility.
Adds a migration that moves imports of `DOCUMENT` from `common` to `core`.
devversion
approved these changes
Apr 1, 2025
| const {position, end, toInsert} = current.update.data; | ||
| const key = current.projectFile.id + '/' + position + '/' + end + '/' + toInsert; | ||
|
|
||
| if (!seen.has(key)) { |
Member
There was a problem hiding this comment.
We should really come up with something for this 😄
devversion
approved these changes
Apr 1, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
thePunderWoman
approved these changes
Apr 1, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 1, 2025
Adds a migration that moves imports of `DOCUMENT` from `common` to `core`. PR Close #60663
Contributor
|
This PR was merged into the repository by commit accc65c. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
DOCUMENTtoken fromcommonintocoresince it's relevant for lots of SSR use cases and users shouldn't have to installcommonfor it. The token is still exported throughcommonfor backwards compatibility.