build: remove obsolete bundling test apps#60591
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
build: remove obsolete bundling test apps#60591AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
pkozlowski-opensource
approved these changes
Mar 27, 2025
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
66ca019 to
be5a829
Compare
This commit removes a few bundling test apps that do not provide any value, but require time on CI and during local development to update golden files. The functionality that was tested in those apps is covered by various other tests that we have in a repository (either in the same `packages/core/test/bundling` folder or in other unit/integration tests).
be5a829 to
812deda
Compare
Contributor
|
This PR was merged into the repository by commit cbd6ec8. The changes were merged into the following branches: main |
2 tasks
thePunderWoman
pushed a commit
to AndrewKushnir/angular
that referenced
this pull request
Mar 28, 2025
This commit removes a few bundling test apps that do not provide any value, but require time on CI and during local development to update golden files. The functionality that was tested in those apps is covered by various other tests that we have in a repository (either in the same `packages/core/test/bundling` folder or in other unit/integration tests). PR Close angular#60591
thePunderWoman
pushed a commit
that referenced
this pull request
Mar 28, 2025
This commit removes a few bundling test apps that do not provide any value, but require time on CI and during local development to update golden files. The functionality that was tested in those apps is covered by various other tests that we have in a repository (either in the same `packages/core/test/bundling` folder or in other unit/integration tests). PR Close #60591 PR Close #60615
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this pull request
Apr 2, 2025
Those targets where removed by angular#60591 but the symbols files were left behind.
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 2, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes a few bundling test apps that do not provide any value, but require time on CI and during local development to update golden files.
The functionality that was tested in those apps is covered by various other tests that we have in a repository (either in the same
packages/core/test/bundlingfolder or in other unit/integration tests).Does this PR introduce a breaking change?