test: add integration test to ensure all exported modules can be imported#60489
Closed
devversion wants to merge 1 commit intoangular:mainfrom
Closed
test: add integration test to ensure all exported modules can be imported#60489devversion wants to merge 1 commit intoangular:mainfrom
devversion wants to merge 1 commit intoangular:mainfrom
Conversation
…rted This commit adds a new integration test which will help ensure that all exported `@NgModule`'s of framework packages can be imported by users without any errors. This test is generally useful, but with our upcoming changes with relative imports, this is a good safety-net. Relative imports could break re-exported NgModules inside NgModule's. For more details, see: angular/components#30667 Notably we don't expect any issues for framework package as re-exporting `@NgModule`'s inside `@NgModule`'s is seemingly a rather rare pattern for APF libraries (confirmed by Material only having like 4-5 instances).
crisbeto
approved these changes
Mar 20, 2025
Member
|
This PR was merged into the repository by commit 6890eab. The changes were merged into the following branches: main, 19.2.x |
alxhub
pushed a commit
that referenced
this pull request
Mar 20, 2025
…rted (#60489) This commit adds a new integration test which will help ensure that all exported `@NgModule`'s of framework packages can be imported by users without any errors. This test is generally useful, but with our upcoming changes with relative imports, this is a good safety-net. Relative imports could break re-exported NgModules inside NgModule's. For more details, see: angular/components#30667 Notably we don't expect any issues for framework package as re-exporting `@NgModule`'s inside `@NgModule`'s is seemingly a rather rare pattern for APF libraries (confirmed by Material only having like 4-5 instances). PR Close #60489
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new integration test which will help ensure that all exported
@NgModule's of framework packages can be imported by users without any errors.This test is generally useful, but with our upcoming changes with relative imports, this is a good safety-net. Relative imports could break re-exported NgModules inside NgModule's. For more details, see: angular/components#30667
Notably we don't expect any issues for framework package as re-exporting
@NgModule's inside@NgModule's is seemingly a rather rare pattern for APF libraries (confirmed by Material only having like 4-5 instances).