Resolve host binding type issues #60481
Conversation
There was a problem hiding this comment.
I removed the string interpolation here, because it was preventing type checking. It also seemed like it was there purely for the unit tests.
There was a problem hiding this comment.
These had to be made protected, because it's not allowed to use private methods in templates/host bindings.
There was a problem hiding this comment.
These are cast to any, because $event.target is an EventTarget and we have no way of casting it to HTMLInputElement. The other option we be to have a type assertion in a separate method, but I didn't want to add more runtime code here.
e305e2e to
6d83cbf
Compare
c27cef3 to
25d60e4
Compare
Enables strict templates and type checking of host bindings against our own code.
Fixes type checking issues in the dev tools that weren't showing up, because we had `strictTemplates` turned off.
Fixes type issues in the host bindings of `NgOptimizedImage`.
Fixes some type issues that are being flagged now that we have type checking of host bindings.
Resolves typing issues inside host binding in adev.
Fixes some type checking issues in our own testing code that weren't showing up, because `strictTemplates` was turned off.
25d60e4 to
4d6d1cc
Compare
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
devversion
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
|
This PR was merged into the repository by commit 911ad40. The changes were merged into the following branches: main |
Fixes type checking issues in the dev tools that weren't showing up, because we had `strictTemplates` turned off. PR Close #60481
Fixes type issues in the host bindings of `NgOptimizedImage`. PR Close #60481
Fixes some type issues that are being flagged now that we have type checking of host bindings. PR Close #60481
Resolves typing issues inside host binding in adev. PR Close #60481
Fixes some type checking issues in our own testing code that weren't showing up, because `strictTemplates` was turned off. PR Close #60481
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates our build setup to type check host bindings in our own directives, and fixes any pre-existing issues. This is a prerequisite for enabling the new type checking internally.