Skip to content

ci: fix flakey defer test#60461

Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman:defer-test-fix
Closed

ci: fix flakey defer test#60461
thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman:defer-test-fix

Conversation

@thePunderWoman
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman commented Mar 19, 2025

This uses a fake timer scheduler implementation to ensure timer tests do not cause flakiness, similar to the incremental hydration tests.

@thePunderWoman
ci: fix flakey defer test
0962150 
This uses a fake timer scheduler implementation to ensure timer tests do not cause flakiness, similar to the incremental hydration tests.
@thePunderWoman thePunderWoman added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 19, 2025
@ngbot ngbot bot modified the milestone: Backlog Mar 19, 2025
JeanMeche
JeanMeche approved these changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is probably a correct workaround but let's maybe escalate the issue to see if someone has an idea of what the root cause could be.

The flakiness fixed by #60448 probably has the same root cause.

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Mar 19, 2025

This PR was merged into the repository by commit c7cacbf.

The changes were merged into the following branches: main, 19.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Mar 19, 2025
@thePunderWoman @pkozlowski-opensource
ci: fix flakey defer test (#60461)
d306e31 
This uses a fake timer scheduler implementation to ensure timer tests do not cause flakiness, similar to the incremental hydration tests.

PR Close #60461
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Apr 19, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2025
@thePunderWoman thePunderWoman deleted the defer-test-fix branch May 23, 2025 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@thePunderWoman @pkozlowski-opensource @JeanMeche @AndrewKushnir