Skip to content

refactor(core): specify reactive node kind for linked signal#60451

Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource:primitives_linked_signal_kind
Closed

refactor(core): specify reactive node kind for linked signal#60451
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource:primitives_linked_signal_kind

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

@pkozlowski-opensource pkozlowski-opensource commented Mar 19, 2025

This commit adds reactive node kind for linked signal.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Mar 19, 2025
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Mar 19, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2025
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 19, 2025
mturco
mturco approved these changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mturco mturco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: shared-primitives

thePunderWoman
thePunderWoman approved these changes Mar 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkozlowski-opensource pkozlowski-opensource removed the request for review from alxhub March 19, 2025 13:41
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2025
@ngbot
Copy link
Copy Markdown

ngbot bot commented Mar 19, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@pkozlowski-opensource pkozlowski-opensource added action: global presubmit The PR is in need of a google3 global presubmit and removed action: merge The PR is ready for merge by the caretaker labels Mar 19, 2025
@pkozlowski-opensource
refactor(core): specify reactive node kind for linked signal
fda4df0 
This commit adds reactive node kind for linked signal.
@pkozlowski-opensource pkozlowski-opensource force-pushed the primitives_linked_signal_kind branch from 7834a8b to fda4df0 Compare March 20, 2025 10:31
@pkozlowski-opensource pkozlowski-opensource added the action: merge The PR is ready for merge by the caretaker label Mar 21, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member Author

pkozlowski-opensource commented Mar 21, 2025

TESTED=deflaked TGP

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: global presubmit The PR is in need of a google3 global presubmit action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 21, 2025
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Mar 24, 2025

This PR was merged into the repository by commit 997836e.

The changes were merged into the following branches: main, 19.2.x

alxhub pushed a commit that referenced this pull request Mar 24, 2025
@pkozlowski-opensource @alxhub
refactor(core): specify reactive node kind for linked signal (#60451)
9ac4057 
This commit adds reactive node kind for linked signal.

PR Close #60451
@alxhub alxhub closed this in 997836e Mar 24, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Apr 24, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mturco mturco mturco approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@pkozlowski-opensource @alxhub @mturco @thePunderWoman @crisbeto