Skip to content

refactor(compiler): Add conditionalCreate instruction#60425

Closed
thePunderWoman wants to merge 2 commits intoangular:mainfrom
thePunderWoman:conditional-create
Closed

refactor(compiler): Add conditionalCreate instruction#60425
thePunderWoman wants to merge 2 commits intoangular:mainfrom
thePunderWoman:conditional-create

Conversation

@thePunderWoman
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman commented Mar 17, 2025

This adds a new instruction for dealing with creating conditionals. It ensures flags are set on the TNode for later identification during hydration.

Does this PR introduce a breaking change?

  • Yes
  • No

@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 17, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 17, 2025
@thePunderWoman thePunderWoman force-pushed the conditional-create branch 5 times, most recently from b0f4de3 to 9413c92 Compare March 18, 2025 14:13
AndrewKushnir
AndrewKushnir reviewed Mar 18, 2025
View reviewed changes
@thePunderWoman thePunderWoman force-pushed the conditional-create branch 2 times, most recently from a8f1402 to 7068c8a Compare March 19, 2025 21:38
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Mar 19, 2025
@thePunderWoman thePunderWoman force-pushed the conditional-create branch 10 times, most recently from 4120a8c to 1f7e02f Compare March 20, 2025 17:29
@thePunderWoman thePunderWoman marked this pull request as ready for review March 20, 2025 17:29
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Mar 20, 2025
crisbeto
crisbeto approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the compiler parts.

alxhub
alxhub reviewed Mar 20, 2025
View reviewed changes
AndrewKushnir
AndrewKushnir reviewed Mar 20, 2025
View reviewed changes
@thePunderWoman
refactor(compiler): Add conditionalCreate instruction
ee84509 
This adds a new instruction for dealing with creating conditionals. It ensures flags are set on the TNode for later identification during hydration.
@thePunderWoman thePunderWoman force-pushed the conditional-create branch 2 times, most recently from 3ce7588 to 3235256 Compare March 21, 2025 15:16
@thePunderWoman thePunderWoman force-pushed the conditional-create branch 2 times, most recently from a9c1c5a to 5a01a15 Compare March 21, 2025 18:17
AndrewKushnir
AndrewKushnir reviewed Mar 21, 2025
View reviewed changes
@thePunderWoman
Copy link
Copy Markdown
Contributor Author

thePunderWoman commented Mar 21, 2025 •
edited
Loading

Caretaker notes: This needs cl/739254495 patched in when it lands. Also, the adev test failure is expected due to the new symbols that the npm package has. So this is safe to merge with that test failing.

AndrewKushnir
AndrewKushnir approved these changes Mar 21, 2025
View reviewed changes
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 21, 2025
@thePunderWoman
fix(core): fixes timing of hydration cleanup on control flow
2376cc3 
This properly cleans up stale control flow branches in the case
that branches change between server and client at the same
timing as NgIf / NgSwitch.

fixes: angular#58670
fixes: angular#60218
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Mar 21, 2025

This PR was merged into the repository by commit 13d1c8a.

The changes were merged into the following branches: main

@alxhub alxhub closed this in 58e1d9e Mar 21, 2025
alxhub pushed a commit that referenced this pull request Mar 21, 2025
@thePunderWoman @alxhub
fix(core): fixes timing of hydration cleanup on control flow (#60425)
13d1c8a 
This properly cleans up stale control flow branches in the case
that branches change between server and client at the same
timing as NgIf / NgSwitch.

fixes: #58670
fixes: #60218

PR Close #60425
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Apr 21, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2025
@thePunderWoman thePunderWoman deleted the conditional-create branch May 23, 2025 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub left review comments

@crisbeto crisbeto crisbeto approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@thePunderWoman @alxhub @crisbeto @AndrewKushnir