refactor(migrations): simplify integration of tsurge migrations into the CLI#60386
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
refactor(migrations): simplify integration of tsurge migrations into the CLI#60386crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
…the CLI Currently when we reuse a Tsurge migration is reused externally, there's some glue code that needs to be executed in a specific order. The code gets copied between the different migrations which is error-prone and means that bugs may have to be fixed several times. These changes move the common steps out into a separate function so that only the migration-specific logic (mostly instantiation and logging) is left in the schematic.
devversion
approved these changes
Mar 14, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM. thanks for proactively helping with this!
| getMigration: () => new UnusedImportsMigration(), | ||
| tree, | ||
| beforeProgramCreation: (tsconfigPath) => { | ||
| context.logger.info(`Preparing analysis for ${tsconfigPath}`); |
Member
There was a problem hiding this comment.
Should this be potentially a default log?
Member
Author
There was a problem hiding this comment.
I was debating whether to have default logs, but I went with this approach because some migrations should be silent (e.g. InjectFlags).
| replacements = []; | ||
|
|
||
| for (const {info} of programInfos) { | ||
| const result = await migration.migrate(globalMeta, info); |
Member
There was a problem hiding this comment.
In the future we could probably parallelize that.
Member
|
This PR was merged into the repository by commit c147a0d. The changes were merged into the following branches: main |
JoostK
pushed a commit
to JoostK/angular
that referenced
this pull request
Apr 7, 2025
…the CLI (angular#60386) Currently when we reuse a Tsurge migration is reused externally, there's some glue code that needs to be executed in a specific order. The code gets copied between the different migrations which is error-prone and means that bugs may have to be fixed several times. These changes move the common steps out into a separate function so that only the migration-specific logic (mostly instantiation and logging) is left in the schematic. PR Close angular#60386
atscott
pushed a commit
that referenced
this pull request
Apr 8, 2025
…the CLI (#60386) (#60776) Currently when we reuse a Tsurge migration is reused externally, there's some glue code that needs to be executed in a specific order. The code gets copied between the different migrations which is error-prone and means that bugs may have to be fixed several times. These changes move the common steps out into a separate function so that only the migration-specific logic (mostly instantiation and logging) is left in the schematic. PR Close #60386 PR Close #60776
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we reuse a Tsurge migration is reused externally, there's some glue code that needs to be executed in a specific order. The code gets copied between the different migrations which is error-prone and means that bugs may have to be fixed several times.
These changes move the common steps out into a separate function so that only the migration-specific logic (mostly instantiation and logging) is left in the schematic.