refactor(core): pass signal equal function to primitives#60364
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): pass signal equal function to primitives#60364pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Conversation
The signals primitives package understands the equals option now so we can pass it to the signal / computed creation methods instead of manually assigning the equality function on a reactive node.
alxhub
approved these changes
Mar 13, 2025
Member
Author
|
This PR was merged into the repository by commit adecf4c. The changes were merged into the following branches: main, 19.2.x |
pkozlowski-opensource
added a commit
that referenced
this pull request
Mar 13, 2025
The signals primitives package understands the equals option now so we can pass it to the signal / computed creation methods instead of manually assigning the equality function on a reactive node. PR Close #60364
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signals primitives package understands the equals option now so we can pass it to the signal / computed creation methods instead of manually assigning the equality function on a reactive node.