Skip to content

[Patch port] fix(compiler): incorrect spans for template literals (#60323) #60331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

[Patch port] fix(compiler): incorrect spans for template literals (#60323) #60331

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 11, 2025

Note: this is a patch port of #60323.

Fixes that we were producing zero-length spans for template literals and template literal elements.

Fixes #60320.
Fixes #60319.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 11, 2025
@crisbeto crisbeto requested a review from AndrewKushnir March 11, 2025 20:15
@crisbeto
Copy link
Member Author

crisbeto commented Mar 11, 2025

Caretaker note: this is cherry-pick of a PR that has landed already.

@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 11, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 11, 2025
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Mar 11, 2025
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Mar 11, 2025

@crisbeto it looks like there are some legit failures on CI, adding the "cleanup" label for now (and removing the "merge" one).

@crisbeto crisbeto force-pushed the 60320/cherry-pick branch from 0455579 to 7f010ca Compare March 11, 2025 21:05
@crisbeto
Copy link
Member Author

crisbeto commented Mar 11, 2025

oops sorry about that, it should be good now.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 11, 2025
@crisbeto
fix(compiler): incorrect spans for template literals (angular#60323)
e667a6f 
Fixes that we were producing zero-length spans for template literals and template literal elements.

Fixes angular#60320.
Fixes angular#60319.

PR Close angular#60323
@crisbeto crisbeto force-pushed the 60320/cherry-pick branch from 7f010ca to e667a6f Compare March 11, 2025 21:37
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Mar 11, 2025

This PR was merged into the repository by commit 56b551d.

The changes were merged into the following branches: 19.2.x

AndrewKushnir pushed a commit that referenced this pull request Mar 11, 2025
@crisbeto @AndrewKushnir
fix(compiler): incorrect spans for template literals (#60323) (#60331)
56b551d 
Fixes that we were producing zero-length spans for template literals and template literal elements.

Fixes #60320.
Fixes #60319.

PR Close #60323

PR Close #60331
@fisker
Copy link
Contributor

fisker commented Mar 12, 2025 •
edited
Loading

Hello, thanks for the prompt fix, can we release a new version with this?

@JeanMeche
Copy link
Member

JeanMeche commented Mar 12, 2025

@fisker We do a patch release evey week, usually on wednesday us times.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Mar 12, 2025

@fisker Angular v19.2.2, which includes the fix from this PR, was released to NPM a couple minutes ago as a part of the regular release process.

@fisker
Copy link
Contributor

fisker commented Mar 12, 2025

Thank you!

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 12, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @AndrewKushnir @fisker @JeanMeche