fix(platform-server): add missing peer dependency for rxjs#60308
Closed
devversion wants to merge 1 commit intoangular:mainfrom
Closed
fix(platform-server): add missing peer dependency for rxjs#60308devversion wants to merge 1 commit intoangular:mainfrom
rxjs#60308devversion wants to merge 1 commit intoangular:mainfrom
Conversation
The server package imports from `rxjs`, but the dependency was not specified as `peerDependency`, nor `dependency`. This surfaces as an error in strict dependency environments, like with pnpm's symlinked node modules structure. This commit fixes this. It presumably doesn't fail with e.g. Yarn, or npm because of node modules hoisting.
clydin
approved these changes
Mar 10, 2025
AndrewKushnir
approved these changes
Mar 10, 2025
Contributor
|
This PR was merged into the repository by commit 0cff9a1. The changes were merged into the following branches: main, 19.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 10, 2025
The server package imports from `rxjs`, but the dependency was not specified as `peerDependency`, nor `dependency`. This surfaces as an error in strict dependency environments, like with pnpm's symlinked node modules structure. This commit fixes this. It presumably doesn't fail with e.g. Yarn, or npm because of node modules hoisting. PR Close #60308
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server package imports from
rxjs, but the dependency was not specified aspeerDependency, nordependency. This surfaces as an error in strict dependency environments, like with pnpm's symlinked node modules structure.This commit fixes this. It presumably doesn't fail with e.g. Yarn, or npm because of node modules hoisting.