refactor(core): inline standalone check to be dropped#60305
refactor(core): inline standalone check to be dropped#60305arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
|
Isn't that due to |
|
No, it's because ESBuild conservatively assumes that you might still access the variable by name somehow, either by running the code in a global scope or by appending more code to esbuild’s output. |
|
Right, it's related to evanw/esbuild#639. |
|
For the sake of readability wdyt of let errorMessage = '';
if (typeof ngDevMode === 'undefined' || ngDevMode) {
const standalone = !isComponentFactory && isStandalone(componentOrFactory);
errorMessage =
'Cannot bootstrap as there are still asynchronous initializers running.' +
(standalone
? ''
: ' Bootstrap components in the `ngDoBootstrap` method of the root module.');
}
throw new RuntimeError(RuntimeErrorCode.ASYNC_INITIALIZERS_STILL_RUNNING, errorMessage); |
Inlines `standalone` check into the message to be dropped.
ca464b5 to
904e4f2
Compare
|
Updated. |
|
This PR was merged into the repository by commit 526268c. The changes were merged into the following branches: main, 19.2.x |
Inlines `standalone` check into the message to be dropped. PR Close #60305
This fixes the test regression introduced by angular#60305
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Inlines
standalonecheck into the message to be dropped.