refactor(core): log a warning instead of throwing error on `OutputRef…#60293
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): log a warning instead of throwing error on `OutputRef…#60293JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
….emit` when the directive is destroyed. This should not be a hard error, as nothing bad happens but the users should be warned that no event will be emitted. fixes angular#60110
a79be56 to
780593e
Compare
devversion
approved these changes
Mar 9, 2025
| 'Unexpected emit for destroyed `OutputRef`. ' + | ||
| 'The owning directive/component is destroyed.', | ||
| console.warn( | ||
| formatRuntimeError( |
Member
There was a problem hiding this comment.
Do you know if this will still print/expose a stack somehow?
Member
Author
There was a problem hiding this comment.
You got me doubting. Yes the stacktrace is accessible for console warnings.
Contributor
Contributor
|
Caretaker note: the presubmit is "green" (only unrelated failures). |
Contributor
|
This PR was merged into the repository by commit e3afa24. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….emit` when the directive is destroyed.
This should not be a hard error, as nothing bad happens but the users should be warned that no event will be emitted.
fixes #60110