Skip to content

refactor(core): switching to relative imports within the core package#60227

Closed
AndrewKushnir wants to merge 3 commits intoangular:mainfrom
AndrewKushnir:relative_imports_refactor
Closed

refactor(core): switching to relative imports within the core package#60227
AndrewKushnir wants to merge 3 commits intoangular:mainfrom
AndrewKushnir:relative_imports_refactor

Conversation

@AndrewKushnir
Copy link
Copy Markdown
Contributor

This change is needed as a prep work for the upcoming build-related changes.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Mar 5, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 5, 2025
@AndrewKushnir AndrewKushnir added target: patch This PR is targeted for the next patch release state: WIP labels Mar 5, 2025
@AndrewKushnir AndrewKushnir force-pushed the relative_imports_refactor branch from 7f1d0d2 to 9386b17 Compare March 6, 2025 02:56
@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Mar 6, 2025
@AndrewKushnir AndrewKushnir force-pushed the relative_imports_refactor branch from 9386b17 to 62678a1 Compare March 6, 2025 22:58
@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Mar 10, 2025
@AndrewKushnir AndrewKushnir force-pushed the relative_imports_refactor branch 3 times, most recently from 2105d2e to 4ed99dd Compare March 20, 2025 03:59
…e imports

This commit updates scripts within `packages/core/src` to relative imports as a prep work to the upcoming infra updates.
…ve imports

This commit updates scripts within `packages/core/test` to relative imports as a prep work to the
upcoming infra updates.
This commit updates golden files to include the changes that appeared after changing imports to relative paths.
@AndrewKushnir AndrewKushnir force-pushed the relative_imports_refactor branch from 4ed99dd to 1e61a7d Compare March 24, 2025 21:41
@AndrewKushnir AndrewKushnir marked this pull request as ready for review March 24, 2025 22:47
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Mar 24, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor Author

AndrewKushnir commented Mar 24, 2025

Presubmit.

Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: global-dev-infra-approvers

@AndrewKushnir
Copy link
Copy Markdown
Contributor Author

Caretaker note: TGP is "green", this PR is ready for merge.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 25, 2025
@alxhub alxhub added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 25, 2025
@alxhub alxhub closed this in 3d2263c Mar 25, 2025
alxhub pushed a commit that referenced this pull request Mar 25, 2025
…ve imports (#60227)

This commit updates scripts within `packages/core/test` to relative imports as a prep work to the
upcoming infra updates.

PR Close #60227
alxhub pushed a commit that referenced this pull request Mar 25, 2025
This commit updates golden files to include the changes that appeared after changing imports to relative paths.

PR Close #60227
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Mar 25, 2025

This PR was merged into the repository by commit 6d3849f.

The changes were merged into the following branches: main

AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Mar 25, 2025
…e imports (angular#60227)

This commit updates scripts within `packages/core/src` to relative imports as a prep work to the upcoming infra updates.

PR Close angular#60227
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Mar 25, 2025
…ve imports (angular#60227)

This commit updates scripts within `packages/core/test` to relative imports as a prep work to the
upcoming infra updates.

PR Close angular#60227
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Mar 25, 2025
This commit updates golden files to include the changes that appeared after changing imports to relative paths.

PR Close angular#60227
alxhub pushed a commit that referenced this pull request Mar 26, 2025
…e imports (#60227) (#60556)

This commit updates scripts within `packages/core/src` to relative imports as a prep work to the upcoming infra updates.

PR Close #60227

PR Close #60556
alxhub pushed a commit that referenced this pull request Mar 26, 2025
…ve imports (#60227) (#60556)

This commit updates scripts within `packages/core/test` to relative imports as a prep work to the
upcoming infra updates.

PR Close #60227

PR Close #60556
alxhub pushed a commit that referenced this pull request Mar 26, 2025
This commit updates golden files to include the changes that appeared after changing imports to relative paths.

PR Close #60227

PR Close #60556
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants