fix(core): cache ComponentRef inputs and outputs#60156
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): cache ComponentRef inputs and outputs#60156crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
The set of inputs and outputs of a component is static, but the getter for the `inputs` and `outputs` property was re-computing them every time which the user might not expect. These changes add a couple of lines to cache them instead.
pkozlowski-opensource
approved these changes
Feb 28, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
Thnx! This was on my radar as well.
Contributor
|
This PR was merged into the repository by commit af02914. The changes were merged into the following branches: main, 19.2.x |
mmalerba
pushed a commit
that referenced
this pull request
Feb 28, 2025
The set of inputs and outputs of a component is static, but the getter for the `inputs` and `outputs` property was re-computing them every time which the user might not expect. These changes add a couple of lines to cache them instead. PR Close #60156
|
Both the resulting array and the objects with in it are mutable, so a caller can now modify the inputs and outputs of a |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of inputs and outputs of a component is static, but the getter for the
inputsandoutputsproperty was re-computing them every time which the user might not expect. These changes add a couple of lines to cache them instead.