fix(core): prevents event replay from being called on comment nodes#60130
Closed
thePunderWoman wants to merge 2 commits intoangular:mainfrom
Closed
fix(core): prevents event replay from being called on comment nodes#60130thePunderWoman wants to merge 2 commits intoangular:mainfrom
thePunderWoman wants to merge 2 commits intoangular:mainfrom
Conversation
JeanMeche
reviewed
Feb 26, 2025
Member
There was a problem hiding this comment.
Should we add nodeType: number to RNode ?
Contributor
Author
There was a problem hiding this comment.
That's a good question, but I think it can be answered outside of this PR.
4587297 to
0a5f8a9
Compare
b0b1069 to
b1344d5
Compare
6757f62 to
bfd9435
Compare
This updates the event replay tests to make them share the structure and utility functions used by hydration tests. This also resolves some soft errors in the event replay tests.
bfd9435 to
70cb716
Compare
In some rare cases with directives, it is possible that the stash function might be called on a comment node. This actually verifies that the node is an element and exits otherwise. fixes: angular#60070
70cb716 to
1a1a464
Compare
AndrewKushnir
approved these changes
Feb 27, 2025
Contributor
|
This PR was merged into the repository by commit 7ab0a8d. The changes were merged into the following branches: main, 19.2.x |
mmalerba
pushed a commit
that referenced
this pull request
Feb 28, 2025
This updates the event replay tests to make them share the structure and utility functions used by hydration tests. This also resolves some soft errors in the event replay tests. PR Close #60130
mmalerba
pushed a commit
that referenced
this pull request
Feb 28, 2025
mmalerba
pushed a commit
that referenced
this pull request
Feb 28, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some rare cases with directives, it is possible that the stash function might be called on a comment node. This actually verifies that the node is an element and exits otherwise. A second commit also cleans up the event replay tests to use all the same utilities as hydration tests.
fixes: #60070
Does this PR introduce a breaking change?