refactor(core): throw an Cyclic Dependency Error in prod mode#60118
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): throw an Cyclic Dependency Error in prod mode#60118JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
thePunderWoman
approved these changes
Feb 26, 2025
packages/core/src/di/r3_injector.ts
Outdated
Contributor
There was a problem hiding this comment.
Do we have to worry about spherical dependencies? ;)
Member
Author
There was a problem hiding this comment.
What about if the graph is a tesseract ? 😆
Contributor
There was a problem hiding this comment.
Then I guess we'll have to tesser-act fast!
Prior to this change, cyclic injection didn't trigger any error in prod mode, resulting into injecting the `CIRCULAR` object. This could lead to strange errors where no method would be found on the token. fixes angular#60074
035aede to
a7f0c19
Compare
Contributor
|
This PR was merged into the repository by commit 4aeec9f. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, cyclic injection didn't trigger any error in prod mode, resulting into injecting the
CIRCULARobject. This could lead to strange errors where no method would be found on the token.fixes #60074