fix(core): prevent invoking replay listeners on disconnected nodes#60103
Closed
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): prevent invoking replay listeners on disconnected nodes#60103thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
This prevents replay from happening on nodes that have been removed from the DOM. fixes: angular#59841
thePunderWoman
commented
Feb 25, 2025
| } | ||
| } | ||
|
|
||
| export function invokeRegisteredDelegationListeners(event: Event) { |
Contributor
Author
There was a problem hiding this comment.
Turns out this function wasn't being used anywhere.
iteriani
approved these changes
Feb 26, 2025
AndrewKushnir
approved these changes
Feb 27, 2025
Contributor
|
This PR was merged into the repository by commit 0dbf693. The changes were merged into the following branches: main, 19.2.x |
mmalerba
pushed a commit
that referenced
this pull request
Feb 27, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents replay from happening on nodes that have been removed from the DOM.
fixes: #59841
Does this PR introduce a breaking change?