Closed
Conversation
Member
Author
|
Passing-ish TGP. There were a couple of targets that were failing at runtime, but I think they're irrelevant because:
|
pkozlowski-opensource
approved these changes
Feb 21, 2025
d5bedd0 to
c207925
Compare
Reworks the functions that create the `initialInputs`, `inputs` and `outputs` structures to initilize them within the function, instead of returning them to be initialized later. This will simplify future refactors where they'll produce more than one piece of information.
…ones Currently `TNode.inputs`/`TNode.outputs` store all of the available bindings on that node, no matter if they came from a directive that the user applied directly or from a host directive. This has a couple of drawbacks: 1. We need to store more information that necessary. For example, the only reason we have strings in the arrays is to facilitate host directive aliasing. 2. It doesn't allow us to distinguish which host directives belong to which selector-matched directives. These changes are a step towards resolving both issues by storing the host directive binding information in separate data structures.
Reworks the `TNode.inputs` and `TNode.outputs` to not store the public names of bindings. The only reason they were stored was for host directive re-aliasing which is handled through a different data structure now.
c207925 to
58584eb
Compare
Contributor
|
This PR was merged into the repository by commit 628ab40. The changes were merged into the following branches: main, 19.2.x |
kirjs
pushed a commit
that referenced
this pull request
Feb 21, 2025
…ones (#60036) Currently `TNode.inputs`/`TNode.outputs` store all of the available bindings on that node, no matter if they came from a directive that the user applied directly or from a host directive. This has a couple of drawbacks: 1. We need to store more information that necessary. For example, the only reason we have strings in the arrays is to facilitate host directive aliasing. 2. It doesn't allow us to distinguish which host directives belong to which selector-matched directives. These changes are a step towards resolving both issues by storing the host directive binding information in separate data structures. PR Close #60036
kirjs
pushed a commit
that referenced
this pull request
Feb 21, 2025
Reworks the `TNode.inputs` and `TNode.outputs` to not store the public names of bindings. The only reason they were stored was for host directive re-aliasing which is handled through a different data structure now. PR Close #60036
kirjs
pushed a commit
that referenced
this pull request
Feb 21, 2025
Reworks the functions that create the `initialInputs`, `inputs` and `outputs` structures to initilize them within the function, instead of returning them to be initialized later. This will simplify future refactors where they'll produce more than one piece of information. PR Close #60036
kirjs
pushed a commit
that referenced
this pull request
Feb 21, 2025
…ones (#60036) Currently `TNode.inputs`/`TNode.outputs` store all of the available bindings on that node, no matter if they came from a directive that the user applied directly or from a host directive. This has a couple of drawbacks: 1. We need to store more information that necessary. For example, the only reason we have strings in the arrays is to facilitate host directive aliasing. 2. It doesn't allow us to distinguish which host directives belong to which selector-matched directives. These changes are a step towards resolving both issues by storing the host directive binding information in separate data structures. PR Close #60036
kirjs
pushed a commit
that referenced
this pull request
Feb 21, 2025
Reworks the `TNode.inputs` and `TNode.outputs` to not store the public names of bindings. The only reason they were stored was for host directive re-aliasing which is handled through a different data structure now. PR Close #60036
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following refactors around how we store inputs and outputs internally:
refactor(core): rework how inputs/outputs are initialized
Reworks the functions that create the
initialInputs,inputsandoutputsstructures to initilize them within the function, instead of returning them to be initialized later. This will simplify future refactors where they'll produce more than one piece of information.refactor(core): separate host directive inputs from selector-matched ones
Currently
TNode.inputs/TNode.outputsstore all of the available bindings on that node, no matter if they came from a directive that the user applied directly or from a host directive. This has a couple of drawbacks:These changes are a step towards resolving both issues by storing the host directive binding information in separate data structures.
refactor(core): do not store input/output public names
Reworks the
TNode.inputsandTNode.outputsto not store the public names of bindings. The only reason they were stored was for host directive re-aliasing which is handled through a different data structure now.