refactor(core): Ensure fake navigation is not aborted after it succeeds#60028
Closed
atscott wants to merge 3 commits intoangular:mainfrom
Closed
refactor(core): Ensure fake navigation is not aborted after it succeeds#60028atscott wants to merge 3 commits intoangular:mainfrom
atscott wants to merge 3 commits intoangular:mainfrom
Conversation
tbondwilkinson
approved these changes
Feb 20, 2025
The navigate event was only ever being cleared when a new navigation happened. That new navigation would abort the previous one, even if it had already finished successfully.
72481e6 to
1e24651
Compare
This commit updates the implementation of the fake navigation to more closely follow the spec. This includes links to spec parts as well as some reorganization to have the flow of the code more exactly follow the corresponding steps in the spec. This makes it easier to verify that th behavior is correct.
9b782cb to
4a25141
Compare
4a25141 to
093dfe4
Compare
This matches the spec, though there is a bug in chrome that does trigger these events.
093dfe4 to
760f40f
Compare
Contributor
|
This PR was merged into the repository by commit a3575e2. The changes were merged into the following branches: main, 19.2.x |
mmalerba
pushed a commit
that referenced
this pull request
Mar 3, 2025
#60028) This commit updates the implementation of the fake navigation to more closely follow the spec. This includes links to spec parts as well as some reorganization to have the flow of the code more exactly follow the corresponding steps in the spec. This makes it easier to verify that th behavior is correct. PR Close #60028
mmalerba
pushed a commit
that referenced
this pull request
Mar 3, 2025
#60028) This commit updates the implementation of the fake navigation to more closely follow the spec. This includes links to spec parts as well as some reorganization to have the flow of the code more exactly follow the corresponding steps in the spec. This makes it easier to verify that th behavior is correct. PR Close #60028
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigate event was only ever being cleared when a new navigation happened. That new navigation would abort the previous one, even if it had already finished successfully.