docs: Remove misleading default value DEFAULT_CURRENCY_CODE#59977
docs: Remove misleading default value DEFAULT_CURRENCY_CODE#59977michelAlexis wants to merge 1 commit intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
packages/core/src/i18n/tokens.ts
Outdated
There was a problem hiding this comment.
I think we need to also remove the deprecation notice.
JeanMeche
left a comment
There was a problem hiding this comment.
Please also remove the deprecation notice
|
Caretaker note: this is docs only and does not need a presubmit. |
|
This PR was merged into the repository by commit 6f6d9f1. The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current documentation for
DEFAULT_CURRENCY_CODEstates the following :This is currently not the case, and is apparently not the desired behavior. #34724 (comment)
Multiple issues have been created about this, but the documentation has never been updated.
#41323
#47612
What is the new behavior?
Remove the "derived from locale" sentences and fix the default doc value as
USD.Does this PR introduce a breaking change?
Other information
First time doing a public PR, if I missed something in the guidlines let me know