fix(compiler-cli): avoid crash in isolated transform operations#59869
Closed
JoostK wants to merge 3 commits intoangular:mainfrom
Closed
fix(compiler-cli): avoid crash in isolated transform operations#59869JoostK wants to merge 3 commits intoangular:mainfrom
JoostK wants to merge 3 commits intoangular:mainfrom
Conversation
dfb8554 to
d934576
Compare
devversion
reviewed
Feb 6, 2025
Member
There was a problem hiding this comment.
Is this a risk meaning that sometimes we may not be able to properly preserve?
Member
Author
There was a problem hiding this comment.
Good question; I'm not 100% certain. My reasoning for this change was that without an emit resolver, the set to build here would never be consumed. I should write a test specifically for this transformer to see if it behaves correctly.
The CLI uses the `ts.transform` API to apply the Angular compiler's transformers on the source files when `isolatedModules` is true (and various other constraints) instead of going through a full `ts.Program.emit` operation. This results in the transformers to operate in an environment where no emit resolver is available, which was not previously accounted for. This commit reflects the possibility for the emit resolver to be missing and handles this scenario accordingly. Fixes angular#59837
3871a4f to
32cf5d7
Compare
devversion
approved these changes
Feb 10, 2025
Contributor
|
This PR was merged into the repository by commit 973033a. The changes were merged into the following branches: main, 19.1.x |
thePunderWoman
pushed a commit
that referenced
this pull request
Feb 13, 2025
The CLI uses the `ts.transform` API to apply the Angular compiler's transformers on the source files when `isolatedModules` is true (and various other constraints) instead of going through a full `ts.Program.emit` operation. This results in the transformers to operate in an environment where no emit resolver is available, which was not previously accounted for. This commit reflects the possibility for the emit resolver to be missing and handles this scenario accordingly. Fixes #59837 PR Close #59869
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI uses the
ts.transformAPI to apply the Angular compiler's transformers on the source files whenisolatedModulesis true (and various other constraints) instead of going through a fullts.Program.emitoperation. This results in the transformers to operate in an environment where no emit resolver is available, which was not previously accounted for. This commit reflects the possibility for the emit resolver to be missing and handles this scenario accordingly.Fixes #59837