refactor(core): move directive matching logic to a separate file#59843
Closed
pkozlowski-opensource wants to merge 4 commits intoangular:mainfrom
Closed
refactor(core): move directive matching logic to a separate file#59843pkozlowski-opensource wants to merge 4 commits intoangular:mainfrom
pkozlowski-opensource wants to merge 4 commits intoangular:mainfrom
Conversation
eneajaho
reviewed
Feb 3, 2025
77309cd to
1174e64
Compare
Move directive matching logic to a separate file.
1174e64 to
07d12ff
Compare
Reuse element first create pass in ComponentRef.
Reuse element end first creation pass in ComponentRef impl.
badfaae to
44668cc
Compare
crisbeto
approved these changes
Feb 4, 2025
Some minor code cleanups after code changes in previous commits.
alxhub
approved these changes
Feb 5, 2025
Member
|
This PR was merged into the repository by commit 41b1a7c. The changes were merged into the following branches: main, 19.1.x |
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2025
Reuse element first create pass in ComponentRef. PR Close #59843
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2025
Reuse element end first creation pass in ComponentRef impl. PR Close #59843
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2025
Some minor code cleanups after code changes in previous commits. PR Close #59843
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2025
) Move directive matching logic to a separate file. PR Close #59843
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2025
Reuse element first create pass in ComponentRef. PR Close #59843
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2025
Reuse element end first creation pass in ComponentRef impl. PR Close #59843
alxhub
pushed a commit
that referenced
this pull request
Feb 5, 2025
Some minor code cleanups after code changes in previous commits. PR Close #59843
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ular#59843) Move directive matching logic to a separate file. PR Close angular#59843
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…lar#59843) Reuse element first create pass in ComponentRef. PR Close angular#59843
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Reuse element end first creation pass in ComponentRef impl. PR Close angular#59843
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Some minor code cleanups after code changes in previous commits. PR Close angular#59843
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move directive matching logic to a separate file.