refactor(core): reuse existing logic in ComponentRef impl#59806
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Closed
Conversation
This change removes some code and logic duplication by re-using the existing functionality. It also pulls some code into separate methods for clarity.
2d22518 to
bef0c66
Compare
AndrewKushnir
approved these changes
Jan 31, 2025
atscott
approved these changes
Feb 3, 2025
Member
|
This PR was merged into the repository by commit 2d53bac. The changes were merged into the following branches: main, 19.1.x |
alxhub
pushed a commit
that referenced
this pull request
Feb 3, 2025
This change removes some code and logic duplication by re-using the existing functionality. It also pulls some code into separate methods for clarity. PR Close #59806
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
) This change removes some code and logic duplication by re-using the existing functionality. It also pulls some code into separate methods for clarity. PR Close angular#59806
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes some code and logic duplication by
re-using the existing functionality. It also pulls some
code into separate methods for clarity.