Skip to content

fix(elements): not setting initial value on signal-based input#59773

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:59757/elements-signal-inputs
Closed

fix(elements): not setting initial value on signal-based input#59773
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:59757/elements-signal-inputs

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Fixes that createCustomElement was incorrectly excluding signal-based inputs when setting the initial values.

Fixes #59757.

Fixes that `createCustomElement` was incorrectly excluding signal-based inputs when setting the initial values.

Fixes angular#59757.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 29, 2025
@angular-robot angular-robot bot added the area: elements Issues related to Angular Elements label Jan 29, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 29, 2025
@crisbeto
Copy link
Copy Markdown
Member Author

Passing TGP

@crisbeto crisbeto requested a review from alxhub January 29, 2025 11:09
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 29, 2025
@crisbeto crisbeto marked this pull request as ready for review January 29, 2025 11:09
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 29, 2025
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Jan 29, 2025

This PR was merged into the repository by commit 0c1ecb4.

The changes were merged into the following branches: main, 19.1.x

alxhub pushed a commit that referenced this pull request Jan 29, 2025
Fixes that `createCustomElement` was incorrectly excluding signal-based inputs when setting the initial values.

Fixes #59757.

PR Close #59773
@alxhub alxhub closed this in 0c1ecb4 Jan 29, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
…ar#59773)

Fixes that `createCustomElement` was incorrectly excluding signal-based inputs when setting the initial values.

Fixes angular#59757.

PR Close angular#59773
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: elements Issues related to Angular Elements target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular 19 - Signal Inputs and Web Components routed vs page load

2 participants