Decouple platform-server from animations#59762
Closed
crisbeto wants to merge 3 commits intoangular:mainfrom
Closed
Decouple platform-server from animations#59762crisbeto wants to merge 3 commits intoangular:mainfrom
crisbeto wants to merge 3 commits intoangular:mainfrom
Conversation
0c51b0f to
5f5a9e2
Compare
crisbeto
commented
Jan 28, 2025
Uses `ngServerMode` to automatically disable browser animations on the server. This allows us to decouple `platform-server` from the animations package.
Removes the hard dependency between `platform-server` and `platform-browser/animations` since now the animations module will disable itself automatically.
We had some tests that were relying on the fact that the server module was importing animations implicitly.
5f5a9e2 to
8bea2c4
Compare
AndrewKushnir
approved these changes
Jan 28, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for the improvement @crisbeto 👍
thePunderWoman
approved these changes
Jan 28, 2025
kirjs
approved these changes
Jan 28, 2025
Member
|
This PR was merged into the repository by commit ea2ea5e. The changes were merged into the following branches: main |
alxhub
pushed a commit
that referenced
this pull request
Jan 29, 2025
Removes the hard dependency between `platform-server` and `platform-browser/animations` since now the animations module will disable itself automatically. PR Close #59762
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…angular#59762) Uses `ngServerMode` to automatically disable browser animations on the server. This allows us to decouple `platform-server` from the animations package. PR Close angular#59762
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…#59762) Removes the hard dependency between `platform-server` and `platform-browser/animations` since now the animations module will disable itself automatically. PR Close angular#59762
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ule (angular#59762) We had some tests that were relying on the fact that the server module was importing animations implicitly. PR Close angular#59762
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Feb 12, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
alan-agius4
pushed a commit
to angular/angular-cli
that referenced
this pull request
Feb 13, 2025
Previously the animations module was added to the `ng new` app, because `platform-server` was using it. That's no longer the case as of angular/angular#59762 so these changes remove the dependency.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following changes that should remove the hard dependency between
platform-serverand the animations module:fix(platform-browser): automatically disable animations on the server
Uses
ngServerModeto automatically disable browser animations on the server. This allows us to decoupleplatform-serverfrom the animations package.fix(platform-server): decouple server from animations module
Removes the hard dependency between
platform-serverandplatform-browser/animationssince now the animations module will disable itself automatically.test(core): update tests that were relying on implicit animations module
We had some tests that were relying on the fact that the server module was importing animations implicitly.