Closed
Conversation
pkozlowski-opensource
requested changes
Jan 28, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
Thnx for the PR. While we could change to the slice usage I feel like most of the added comments just repeat what is written in the code and add to the noise instead of helping.
alan-agius4
reviewed
Jan 28, 2025
alan-agius4
reviewed
Jan 28, 2025
becc66e to
551db8a
Compare
Contributor
Author
|
@pkozlowski-opensource removed comments. |
551db8a to
832b85e
Compare
Contributor
Author
|
@alan-agius4 I removed |
alfaproject
reviewed
Jan 28, 2025
832b85e to
f70b370
Compare
f70b370 to
a83c263
Compare
a83c263 to
f6bc3aa
Compare
In this commit, we improve branching in the `stringify` function, which is widely used by the framework, and add additional comments for clarification. Benchmark results of the old and new implementations (using `slice` makes it slightly faster) are as follows: ``` stringify (old version) x 117,945,419 ops/sec ±5.25% (55 runs sampled) stringify (new version) x 136,692,820 ops/sec ±4.82% (56 runs sampled) ```
f6bc3aa to
3d496a2
Compare
pkozlowski-opensource
approved these changes
Feb 19, 2025
thePunderWoman
pushed a commit
that referenced
this pull request
Feb 19, 2025
In this commit, we improve branching in the `stringify` function, which is widely used by the framework, and add additional comments for clarification. Benchmark results of the old and new implementations (using `slice` makes it slightly faster) are as follows: ``` stringify (old version) x 117,945,419 ops/sec ±5.25% (55 runs sampled) stringify (new version) x 136,692,820 ops/sec ±4.82% (56 runs sampled) ``` PR Close #59745
Contributor
|
This PR was merged into the repository by commit cf3a507. The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we improve branching in the
stringifyfunction, which is widely used by the framework, and add additional comments for clarification. Benchmark results of the old and new implementations (usingslicemakes it slightly faster) are as follows: