Skip to content

fix(platform-browser): Update pseudoevent created by createMouseSpecialEvent to populate _originalEvent property#59690

Closed
seabasso wants to merge 3 commits intoangular:mainfrom
seabasso:events
Closed

fix(platform-browser): Update pseudoevent created by createMouseSpecialEvent to populate _originalEvent property#59690
seabasso wants to merge 3 commits intoangular:mainfrom
seabasso:events

Conversation

@seabasso
Copy link
Copy Markdown
Contributor

@seabasso seabasso commented Jan 23, 2025 •
edited
Loading

This fixes an internal bug.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@seabasso
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
e379b4b 
…alEvent to populate `_originalEvent` property

This fixes an internal bug.
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Jan 23, 2025
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 23, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2025
@tbondwilkinson tbondwilkinson requested review from tbondwilkinson and removed request for iteriani January 23, 2025 23:56
thePunderWoman
thePunderWoman approved these changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like the lint check is failing for file formatting reasons.
Can you run yarn ng-dev format files packages/core/primitives/event-dispatch/src/event.ts and then force push? That'll fix it.

reviewed-for: primitives

@thePunderWoman thePunderWoman added target: patch This PR is targeted for the next patch release action: global presubmit The PR is in need of a google3 global presubmit action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 24, 2025
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Jan 24, 2025

TESTED=TGP

@seabasso
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
1ccd933 
…alEvent to populate `_originalEvent` property

This fixes an internal bug
@pullapprove pullapprove bot requested a review from josephperrott January 24, 2025 18:20
@seabasso
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
e493fac 
…alEvent to populate `_originalEvent` property

This fixes an internal bug
@seabasso
Copy link
Copy Markdown
Contributor Author

seabasso commented Jan 24, 2025

Passing TGP

@tbondwilkinson tbondwilkinson added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: global presubmit The PR is in need of a google3 global presubmit labels Jan 24, 2025
@tbondwilkinson tbondwilkinson removed the request for review from josephperrott January 24, 2025 20:02
@alan-agius4 alan-agius4 added the merge: squash commits When the PR is merged, a squash and merge should be performed label Jan 24, 2025
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Jan 27, 2025

This PR was merged into the repository by commit fd7ee47.

The changes were merged into the following branches: main, 19.1.x

pkozlowski-opensource pushed a commit that referenced this pull request Jan 27, 2025
@seabasso @pkozlowski-opensource
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
65cf061 
…alEvent to populate `_originalEvent` property (#59690)

This fixes an internal bug

PR Close #59690
pkozlowski-opensource pushed a commit that referenced this pull request Jan 27, 2025
@seabasso @pkozlowski-opensource
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
fd7ee47 
…alEvent to populate `_originalEvent` property (#59690)

This fixes an internal bug

PR Close #59690
pkozlowski-opensource pushed a commit that referenced this pull request Jan 27, 2025
@seabasso @pkozlowski-opensource
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
3f4d5f6 
…alEvent to populate `_originalEvent` property (#59690)

This fixes an internal bug.

PR Close #59690
pkozlowski-opensource pushed a commit that referenced this pull request Jan 27, 2025
@seabasso @pkozlowski-opensource
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
1225657 
…alEvent to populate `_originalEvent` property (#59690)

This fixes an internal bug

PR Close #59690
pkozlowski-opensource pushed a commit that referenced this pull request Jan 27, 2025
@seabasso @pkozlowski-opensource
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
1c84cbc 
…alEvent to populate `_originalEvent` property (#59690)

This fixes an internal bug

PR Close #59690
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@seabasso @PrajaktaB27
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
fb12772 
…alEvent to populate `_originalEvent` property (angular#59690)

This fixes an internal bug.

PR Close angular#59690
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@seabasso @PrajaktaB27
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
1345631 
…alEvent to populate `_originalEvent` property (angular#59690)

This fixes an internal bug

PR Close angular#59690
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@seabasso @PrajaktaB27
fix(platform-browser): Update pseudoevent created by createMouseSpeci…
6962d89 
…alEvent to populate `_originalEvent` property (angular#59690)

This fixes an internal bug

PR Close angular#59690
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Feb 27, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: squash commits When the PR is merged, a squash and merge should be performed requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@seabasso @thePunderWoman @pkozlowski-opensource @tbondwilkinson @alan-agius4