Skip to content

refactor(core): remove unused APP_EFFECT_SCHEDULER in effect code#59679

Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:refactor/unused-effect-code
Closed

refactor(core): remove unused APP_EFFECT_SCHEDULER in effect code#59679
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:refactor/unused-effect-code

Conversation

@cexbrayat
Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

The APP_EFFECT_SCHEDULER Injection token is never used and not a public API.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The `APP_EFFECT_SCHEDULER` Injection token is never used and not a public API.
@pullapprove pullapprove bot requested a review from alxhub January 23, 2025 11:33
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 23, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2025
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Usage in G3, should be good to go

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 30, 2025
@pkozlowski-opensource pkozlowski-opensource removed the request for review from alxhub April 30, 2025 09:15
mmalerba pushed a commit that referenced this pull request Apr 30, 2025
…59679)

The `APP_EFFECT_SCHEDULER` Injection token is never used and not a public API.

PR Close #59679
@mmalerba
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 52e2f08.

The changes were merged into the following branches: main, 19.2.x

@mmalerba mmalerba closed this in 52e2f08 Apr 30, 2025
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants