Skip to content

fix(core): cleanup stash listener when app is destroyed#59598

Closed
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/core-cleanup-stashfn
Closed

fix(core): cleanup stash listener when app is destroyed#59598
arturovt wants to merge 1 commit intoangular:mainfrom
arturovt:fix/core-cleanup-stashfn

Conversation

@arturovt
Copy link
Copy Markdown
Contributor

In this commit, we clean up the reference to the function set by the environment initializer, as the function closure may capture injected elements and prevent them from being properly garbage collected.

In this commit, we clean up the reference to the function set by the environment initializer, as the function closure may capture injected elements and prevent them from being properly garbage collected.
@pullapprove pullapprove bot requested a review from kirjs January 17, 2025 14:50
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 17, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 17, 2025
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman removed the request for review from kirjs January 17, 2025 15:38
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 17, 2025
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 14791f3.

The changes were merged into the following branches: main, 19.1.x

AndrewKushnir pushed a commit that referenced this pull request Jan 17, 2025
In this commit, we clean up the reference to the function set by the environment initializer, as the function closure may capture injected elements and prevent them from being properly garbage collected.

PR Close #59598
@arturovt arturovt deleted the fix/core-cleanup-stashfn branch January 17, 2025 19:56
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
In this commit, we clean up the reference to the function set by the environment initializer, as the function closure may capture injected elements and prevent them from being properly garbage collected.

PR Close angular#59598
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants