refactor(core): reuse setupStaticAttributes in ComponentRef#59572
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): reuse setupStaticAttributes in ComponentRef#59572pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
approved these changes
Jan 16, 2025
73d5bf1 to
a23d9e5
Compare
e3c2034 to
256ac6d
Compare
This change refactor how the dynamically created component deals with attributes in order to reuse the existing setupStaticAttributes logic (instead of having specific and similar code).
256ac6d to
f0b6ea1
Compare
Member
Author
|
caretaker note: I've got a "green" TGP for this one. |
Contributor
|
This PR was merged into the repository by commit 35e5bbb. The changes were merged into the following branches: main, 19.1.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 17, 2025
This change refactor how the dynamically created component deals with attributes in order to reuse the existing setupStaticAttributes logic (instead of having specific and similar code). PR Close #59572
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…59572) This change refactor how the dynamically created component deals with attributes in order to reuse the existing setupStaticAttributes logic (instead of having specific and similar code). PR Close angular#59572
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactor how the dynamically created component deals with attributes in order to reuse the existing setupStaticAttributes logic (instead of having specific and similar code).