test(migrations): add test for earlier fix#59497
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
test(migrations): add test for earlier fix#59497crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Adds a test for the fix from angular#59452 now that we know what caused the issue.
crisbeto
commented
Jan 13, 2025
| expect(tree.readContent('comp.ts')).toBe(initialContent); | ||
| }); | ||
|
|
||
| it('should handle a file that is present in multiple projects', async () => { |
Member
Author
There was a problem hiding this comment.
I was considering whether to update groupReplacementsByFile to de-duplicate identical text updates as well. Might be worth waiting to see if this comes up again.
Contributor
There was a problem hiding this comment.
LIkely, synchronouslyCombineUnitData needs to be fixed instead of groupReplacementsByFile. As pretty much everything is duplicate.
devversion
approved these changes
Jan 13, 2025
Contributor
|
This PR was merged into the repository by commit 9931030. The changes were merged into the following branches: main, 19.1.x |
kirjs
pushed a commit
that referenced
this pull request
Jan 13, 2025
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Adds a test for the fix from angular#59452 now that we know what caused the issue. PR Close angular#59497
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test for the fix from #59452 now that we know what caused the issue.