refactor(core): move logic out of shared instructions code#59453
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): move logic out of shared instructions code#59453pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
Conversation
32bf202 to
7ef67f0
Compare
7ef67f0 to
022a6cb
Compare
AndrewKushnir
approved these changes
Jan 9, 2025
thePunderWoman
approved these changes
Jan 9, 2025
022a6cb to
d6efaa8
Compare
d6efaa8 to
1f87aae
Compare
This is first of a series of refactorings that moves code around such that logic from the shared instruction file is dispatched to the relevant functional parts.
1f87aae to
c3da736
Compare
Member
Author
|
caretaker note: I believe that the G3 failures are pre-existing and unrelated. |
Contributor
|
This PR was merged into the repository by commit af99c6c. The changes were merged into the following branches: main |
Contributor
|
@pkozlowski-opensource FYI, this PR conflicted with the patch branch (19.1.x), so I've merged it into the main only. Could you please create a patch version of this change (to minimize the diff between branches and avoid future merge conflicts) when you get a chance? |
pkozlowski-opensource
added a commit
that referenced
this pull request
Jan 16, 2025
This is first of a series of refactorings that moves code around such that logic from the shared instruction file is dispatched to the relevant functional parts. PR Close #59453
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…9453) This is first of a series of refactorings that moves code around such that logic from the shared instruction file is dispatched to the relevant functional parts. PR Close angular#59453
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is first of a series of refactorings that moves code around such that logic from the shared instruction file is dispatched to the relevant functional parts.