fix(core): Ensure that a destroyed effect never runs#59415
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Ensure that a destroyed effect never runs#59415JeanMeche wants to merge 1 commit intoangular:mainfrom
effect never runs#59415JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
effect never run.effect never runs
Prior to this change, a scheduled root effect, even if destroyed instantly, would still run at least once. This commit fixes this. fixes angular#59410
56de843 to
9fb5898
Compare
eneajaho
reviewed
Jan 8, 2025
Contributor
|
Caretaker note: this is safe to merge. Failing tests are flakes. |
Contributor
|
This PR was merged into the repository by commit 5c0d688. The changes were merged into the following branches: main, 19.0.x |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Prior to this change, a scheduled root effect, even if destroyed instantly, would still run at least once. This commit fixes this. fixes angular#59410 PR Close angular#59415
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, a scheduled root effect, even if destroyed instantly, would still run at least once.
This commit fixes this.
fixes #59410