refactor(platform-browser): drop BROWSER_MODULE_PROVIDERS_MARKER in production#59412
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
refactor(platform-browser): drop BROWSER_MODULE_PROVIDERS_MARKER in production#59412arturovt wants to merge 1 commit intoangular:mainfrom
BROWSER_MODULE_PROVIDERS_MARKER in production#59412arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
9ad7358 to
5951d8d
Compare
… production In this commit, we switch from decorators (which also produce redundant metadata, such as in the `declareFactory` instruction) to the `inject` function to drop the `BROWSER_MODULE_PROVIDERS_MARKER` token in production. This token is actually provided only in development mode but is still referenced in the constructor due to the `@Inject(BROWSER_MODULE_PROVIDERS_MARKER)` decorator.
5951d8d to
42f78aa
Compare
AndrewKushnir
approved these changes
Jan 8, 2025
Contributor
AndrewKushnir
approved these changes
Jan 8, 2025
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
This change affects the constructor signature of the BrowserModule class, but the change looks safe, since we do not support extensions of Angular-provided classes + we do not support instantiation of an NgModule via new.
thePunderWoman
approved these changes
Jan 10, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 17510be. The changes were merged into the following branches: main, 19.1.x |
kirjs
pushed a commit
that referenced
this pull request
Jan 10, 2025
… production (#59412) In this commit, we switch from decorators (which also produce redundant metadata, such as in the `declareFactory` instruction) to the `inject` function to drop the `BROWSER_MODULE_PROVIDERS_MARKER` token in production. This token is actually provided only in development mode but is still referenced in the constructor due to the `@Inject(BROWSER_MODULE_PROVIDERS_MARKER)` decorator. PR Close #59412
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
… production (angular#59412) In this commit, we switch from decorators (which also produce redundant metadata, such as in the `declareFactory` instruction) to the `inject` function to drop the `BROWSER_MODULE_PROVIDERS_MARKER` token in production. This token is actually provided only in development mode but is still referenced in the constructor due to the `@Inject(BROWSER_MODULE_PROVIDERS_MARKER)` decorator. PR Close angular#59412
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we switch from decorators (which also produce redundant metadata, such as in the
declareFactoryinstruction) to theinjectfunction to drop theBROWSER_MODULE_PROVIDERS_MARKERtoken in production. This token is actually provided only in development mode but is still referenced in the constructor due to the@Inject(BROWSER_MODULE_PROVIDERS_MARKER)decorator.