refactor(core): drop DEFER_BLOCK_DEPENDENCY_INTERCEPTOR in production#59381
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): drop DEFER_BLOCK_DEPENDENCY_INTERCEPTOR in production#59381arturovt wants to merge 1 commit intoangular:mainfrom
DEFER_BLOCK_DEPENDENCY_INTERCEPTOR in production#59381arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
`new` expressions are not dropped by default because they are considered side-effectful, even if they are not referenced anywhere in production mode.
728fe96 to
d32ffd0
Compare
Contributor
|
Caretaker note: the test failures were flakes. This is safe to merge. |
Contributor
|
This PR was merged into the repository by commit d9707e1. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…on (angular#59381) `new` expressions are not dropped by default because they are considered side-effectful, even if they are not referenced anywhere in production mode. PR Close angular#59381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newexpressions are not dropped by default because they are considered side-effectful, even if they are not referenced anywhere in production mode.