refactor: remove unnecessary TSLint rule flags#59365
Closed
johnsoncodehk wants to merge 2 commits intoangular:mainfrom
Closed
refactor: remove unnecessary TSLint rule flags#59365johnsoncodehk wants to merge 2 commits intoangular:mainfrom
johnsoncodehk wants to merge 2 commits intoangular:mainfrom
Conversation
85c034d to
f65e0dd
Compare
There are many TSLint rule flags in the source code that have no effect, and they can be safely removed to keep the code clean.
f65e0dd to
9d499fa
Compare
Files in the vendor directory have been excluded in tslint.json.
josephperrott
approved these changes
Jan 6, 2025
Member
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
Contributor
|
TESTED=no TGP needed since this is just removing tslint comments. |
thePunderWoman
pushed a commit
that referenced
this pull request
Jan 7, 2025
There are many TSLint rule flags in the source code that have no effect, and they can be safely removed to keep the code clean. PR Close #59365
Contributor
|
This PR was merged into the repository by commit 9b8f699. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
There are many TSLint rule flags in the source code that have no effect, and they can be safely removed to keep the code clean. PR Close angular#59365
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ls (angular#59365) Files in the vendor directory have been excluded in tslint.json. PR Close angular#59365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I found in #59364 that there are many TSLint rule flags in the source code that have no effect, and after testing they can be safely removed to keep the code clean.