Skip to content

docs: Add NG0750 to errors list#59265

Closed
n0scible wants to merge 1 commit intoangular:mainfrom
n0scible:add-error-NG0750
Closed

docs: Add NG0750 to errors list#59265
n0scible wants to merge 1 commit intoangular:mainfrom
n0scible:add-error-NG0750

Conversation

@n0scible
Copy link
Copy Markdown
Contributor

@n0scible n0scible commented Dec 20, 2024

This PR adds error NG0750 to Error Encyclopedia.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #59218

What is the new behavior?

Error code NG0750 is now visible in Error Encyclopedia.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

NA

@pullapprove pullapprove bot requested a review from AndrewKushnir December 20, 2024 17:31
@angular-robot angular-robot bot added the area: docs Related to the documentation label Dec 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 20, 2024
JeanMeche
JeanMeche reviewed Dec 20, 2024
View reviewed changes
@n0scible n0scible requested a review from JeanMeche December 20, 2024 18:03
AndrewKushnir
AndrewKushnir reviewed Dec 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gitrhyme thanks for adding a more detailed guide for this error. In order to display a link to this guide, could you please also update the error code definition here: https://github.com/angular/angular/blob/main/packages/core/src/errors.ts#L100 and use - sign in front of the error code (see examples in the same file) - that'd indicate to the runtime code that there is a guide available and a link would be automatically added to the error message.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Dec 20, 2024
AndrewKushnir
AndrewKushnir reviewed Dec 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gitrhyme thanks for addressing the feedback! Just added a couple minor proposals. Thank you.

@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Dec 24, 2024

@Gitrhyme thanks for addressing additional comments, the change looks good. Could you please merge all commits into the first one, so that we can do a final review and add the PR to the merge queue? Thank you.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 29, 2024
AndrewKushnir
AndrewKushnir approved these changes Dec 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 29, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Dec 29, 2024

Caretaker note: no additional reviews are required (low risk, docs-only), the PR can be merged.

@pullapprove pullapprove bot requested a review from kirjs January 2, 2025 13:33
kirjs
kirjs reviewed Jan 2, 2025
View reviewed changes
@pullapprove pullapprove bot requested a review from kirjs January 2, 2025 13:35
@n0scible @AndrewKushnir
docs: Add NG0750 to errors list
4a84f03 
This PR adds error NG0750 to Error Encyclopedia.

Update adev/src/content/reference/errors/NG0750.md

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

Update adev/src/content/reference/errors/NG0750.md

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>
@JeanMeche JeanMeche removed the request for review from pkozlowski-opensource January 6, 2025 15:45
thePunderWoman
thePunderWoman approved these changes Jan 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

thePunderWoman pushed a commit that referenced this pull request Jan 6, 2025
@n0scible @thePunderWoman
docs: Add NG0750 to errors list (#59265)
7e40ef2 
This PR adds error NG0750 to Error Encyclopedia.

Update adev/src/content/reference/errors/NG0750.md

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

Update adev/src/content/reference/errors/NG0750.md

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

PR Close #59265
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Jan 6, 2025

This PR was merged into the repository by commit d54deb2.

The changes were merged into the following branches: main, 19.0.x

@n0scible n0scible deleted the add-error-NG0750 branch January 7, 2025 17:07
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Feb 7, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@n0scible @PrajaktaB27
docs: Add NG0750 to errors list (angular#59265)
5f1fbc3 
This PR adds error NG0750 to Error Encyclopedia.

Update adev/src/content/reference/errors/NG0750.md

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

Update adev/src/content/reference/errors/NG0750.md

Co-authored-by: Andrew Kushnir <43554145+AndrewKushnir@users.noreply.github.com>

PR Close angular#59265
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@kirjs kirjs kirjs approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@n0scible @AndrewKushnir @thePunderWoman @JeanMeche @kirjs