Skip to content

refactor(core): reduce generated code#59220

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:defer-promises
Closed

refactor(core): reduce generated code#59220
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:defer-promises

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

This commit updates the defer code promises to reduce a couple of bytes.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 17, 2024
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Dec 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Dec 17, 2024
@alan-agius4 alan-agius4 requested review from thePunderWoman and removed request for pkozlowski-opensource December 17, 2024 16:01
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 17, 2024
@alan-agius4

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 looks great, just one minor comment. We can also address it in a separate PR.

This commit updates the defer code promises to reduce a couple of bytes.
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 17, 2024
@ngbot ngbot bot modified the milestone: Backlog Dec 17, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 17, 2024
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit c181903.

The changes were merged into the following branches: main, 19.0.x

AndrewKushnir pushed a commit that referenced this pull request Dec 17, 2024
This commit updates the defer code promises to reduce a couple of bytes.

PR Close #59220
@alan-agius4 alan-agius4 deleted the defer-promises branch December 18, 2024 06:18
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 18, 2025
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
This commit updates the defer code promises to reduce a couple of bytes.

PR Close angular#59220
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants